Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fail PR if it does not have required labels #8147

Merged
merged 4 commits into from
May 19, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

Fixes #8146

Adding a ci job to fail a PR if it does not have at least one Component: ... label and at least one Type: ... label.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…s in main branch

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Right now this PR fails because it does not have a Type: ... label: https://github.com/vitessio/vitess/runs/2617745882?check_suite_focus=true

Screenshot from 2021-05-19 10-24-46

So i'll now add a Type: ... label and see if CI passes. Note: I will have to trigger the CI manually because the workflow file does not exist in the default branch (master) because that's how it works; when the PR is merged, then CI gets retriggered upon any label change, automatically.

@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach requested review from systay and a team May 19, 2021 07:28
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@systay systay merged commit 6fd06da into vitessio:master May 19, 2021
@systay systay deleted the workflows-ci-require-pr-labels branch May 19, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI job to validate PR labels
2 participants