Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger pr-labels workflow when labels added/removed from PR #8157

Merged
merged 2 commits into from
May 20, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

followup to #8147
the workflow doesn't seem to kick when labels are added to a PR. This PR attempts to fix this.

Related Issue(s)

#8146

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented May 20, 2021

hmmm, pr-labels didn't even trigger when this PR was opened.

@shlomi-noach shlomi-noach marked this pull request as draft May 20, 2021 10:30
@shlomi-noach
Copy link
Contributor Author

pr-labels is not even here right now.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

OK good. Adding a label now triggers pr-labels

@shlomi-noach shlomi-noach marked this pull request as ready for review May 20, 2021 10:49
@shlomi-noach shlomi-noach requested a review from systay May 20, 2021 10:49
@shlomi-noach
Copy link
Contributor Author

this should be good to merge once all tests are green.

@systay
Copy link
Collaborator

systay commented May 20, 2021

beautiful!

@shlomi-noach shlomi-noach merged commit 8d7896f into vitessio:master May 20, 2021
@shlomi-noach shlomi-noach deleted the pr-labels-trigger branch May 20, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants