Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New VReplication lag metric #8306

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jun 10, 2021

Description

Adds a new metric to display vreplication lags in the form of a gauge for easier display in VTAdmin.

Example:

"VReplicationLag": {"1":[1.6,4.8,4.8,4.8,4.8,10.8,13.8,9,4.8,4.8,4.6,4.8,9.6,5.2,10.2,6.4,5.8,6.4,6.4,6.4,6.4,6.4,6.4,6.4,6.4,6.4,7.2,6.4,6.4,6.4,6.4,6.4,6.4,6.4,6.4,9.8,8,8,8.2,7.6,8.4,7.2,8,6.8,6.4],
"10":[4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.6,4.8,4.8,5.2,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,0,0,0,0,0,0,0,0,0],
"11":[4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.4,4.8,4.8,5.2,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,5,0,0,0,0,0,0,0,0,0],
"All":[4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.8,4.6,4.8,4.8,5.2,4.8,4.8,4.8,4.8,4.8,4.

Signed-off-by: Rohit Nayak rohit@planetscale.com

… in VTAdmin

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 10, 2021
@rohit-nayak-ps rohit-nayak-ps requested review from ajm188 and a team June 10, 2021 15:35
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review June 10, 2021 15:36
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally + it worked as promised! 🎉 Thanks, this will be great to have.

@shlomi-noach shlomi-noach merged commit b25b34e into vitessio:main Jun 13, 2021
@shlomi-noach shlomi-noach deleted the rn-vrlag-stat branch June 13, 2021 08:52
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants