[vtadmin-web] Add chart for stream vreplication lag across all streams in a workflow #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
…to show Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
changed the title
doeg
added
Component: VReplication
Component: VTAdmin
ajm188
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a chart to the Workflow view that graphs the vreplication lag across all streams in the workflow. Many thanks to @rohit-nayak-ps for adding these stats for us in #8306!
Here's what it looks like before/after the cutover in a reshard workflow:
And here's the MoveTables workflow from the local example, for fun:
Related Issue(s)
Checklist
Deployment Notes
This PR depends on #8306, which adds the
VReplicationLagmetric to the tablet /debug/vars endpoint. For Vitess deployments without that change, the chart will still render but no data will be shown. (More helpful error handling will be added to all charts as part of https://github.com/vitessio/vitess/projects/12#card-63086237.)