sqlparser: Limit nesting of parenthesized exprs #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #767 as well as other situations where there's possibility of indefinite nesting of SQL constructs. There may be other non-aprentheszed constructs that allow nesting, but this fix doesn't address them for now. I've also made a few lint fixes. sql.go is still in violation, but that requires bigger work.
|
LGTM |
The previous change only handled nesting for one construt. This change extends the limit to all parenthesized constructs.
|
Going to merge the additional additional change also, since it's just an extension of the previous one. |
sougou
added a commit
that referenced
this pull request
Jul 4, 2015
sqlparser: Limit nesting of parenthesized exprs
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
* Refresh rice box Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix incorrect workflows Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Sync after running make vtadmin_web_proto_types Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update message test to account for new interface Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Try running with node v 16 Signed-off-by: notfelineit <notfelineit@gmail.com> * Install @testing-library/user-event Signed-off-by: notfelineit <notfelineit@gmail.com> * test: remove planner-version flag change Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #767
as well as other situations where there's possibility of
indefinite nesting of SQL constructs. There may be other
non-parenthesized constructs that allow nesting, but this fix
doesn't address them for now.
I've also made a few lint fixes. sql.go is still in violation,
but that requires bigger work.