-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve upgrade downgrade workflows' strategy #9745
Merged
frouioui
merged 8 commits into
vitessio:main
from
planetscale:improve-upgrade-downgrade-strategy
Feb 23, 2022
Merged
Improve upgrade downgrade workflows' strategy #9745
frouioui
merged 8 commits into
vitessio:main
from
planetscale:improve-upgrade-downgrade-strategy
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
force-pushed
the
improve-upgrade-downgrade-strategy
branch
from
February 21, 2022 07:23
f0144e4
to
4b04546
Compare
frouioui
added
Component: Build/CI
release notes none
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Feb 21, 2022
…rade build Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
improve-upgrade-downgrade-strategy
branch
4 times, most recently
from
February 21, 2022 07:57
5e6be29
to
c2b9e6c
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…lows Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
improve-upgrade-downgrade-strategy
branch
from
February 21, 2022 08:05
c2b9e6c
to
10d5a53
Compare
GuptaManan100
approved these changes
Feb 21, 2022
…ease branches Signed-off-by: Manan Gupta <manan@planetscale.com>
…ase brach if no tag exists for the latest release branch Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Can't approve my own PR. But I approve @GuptaManan100's latest changes. |
deepthi
reviewed
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is that we seem to be duplicating config in each upgrade/downgrade test.
Maybe we should write our own custom action and use that for all of these tests.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@GuptaManan100 and I paired up on this pull request to improve the upgrade downgrade testing workflows by choosing the latest release in a better way.
Before, every commit would be tested against the last major release, even if this commit is made on, for instance, the
release-12.0
branch.Now, commits made against a release branch are tested against the previous release branch (commits torelease-13.0
will be tested againstrelease-12.0
) ; and commits made tomain
and other branches are tested against the latest release branch.Now, commits made against a release branch are tested against the previous releases' latest patch release and commits made to
main
and other branches are tested against the last major release tag unless a new release brach has been created without a tag, in which case that is used.For example -
release-13.0
v12.0.3
release-12.0
v11.0.4
main
v13.0.0
main
(after we createrelease-14.0
but before creatingv14.0.0
)release-14.0
Needs to be backported to all three latest releases, but does not need to make it to
v13.0.0 GA
.Checklist