Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgrade downgrade workflows' strategy #9745

Merged

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 21, 2022

Description

@GuptaManan100 and I paired up on this pull request to improve the upgrade downgrade testing workflows by choosing the latest release in a better way.

Before, every commit would be tested against the last major release, even if this commit is made on, for instance, the release-12.0 branch. Now, commits made against a release branch are tested against the previous release branch (commits to release-13.0 will be tested against release-12.0) ; and commits made to main and other branches are tested against the latest release branch.
Now, commits made against a release branch are tested against the previous releases' latest patch release and commits made to main and other branches are tested against the last major release tag unless a new release brach has been created without a tag, in which case that is used.

For example -

PR head Tested against
release-13.0 v12.0.3
release-12.0 v11.0.4
main v13.0.0
main (after we create release-14.0 but before creating v14.0.0) release-14.0

Needs to be backported to all three latest releases, but does not need to make it to v13.0.0 GA.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui frouioui force-pushed the improve-upgrade-downgrade-strategy branch from f0144e4 to 4b04546 Compare February 21, 2022 07:23
@frouioui frouioui added Component: Build/CI release notes none Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Feb 21, 2022
…rade build

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the improve-upgrade-downgrade-strategy branch 4 times, most recently from 5e6be29 to c2b9e6c Compare February 21, 2022 07:57
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…lows

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the improve-upgrade-downgrade-strategy branch from c2b9e6c to 10d5a53 Compare February 21, 2022 08:05
@GuptaManan100 GuptaManan100 marked this pull request as ready for review February 21, 2022 08:39
@GuptaManan100 GuptaManan100 marked this pull request as draft February 21, 2022 08:44
…ease branches

Signed-off-by: Manan Gupta <manan@planetscale.com>
…ase brach if no tag exists for the latest release branch

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review February 23, 2022 08:20
@frouioui
Copy link
Member Author

Can't approve my own PR. But I approve @GuptaManan100's latest changes.

@frouioui frouioui merged commit 5ad5925 into vitessio:main Feb 23, 2022
@frouioui frouioui deleted the improve-upgrade-downgrade-strategy branch February 23, 2022 11:21
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that we seem to be duplicating config in each upgrade/downgrade test.
Maybe we should write our own custom action and use that for all of these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants