Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vttestserver: add enable_system_settings option #9779

Conversation

brendar
Copy link
Contributor

@brendar brendar commented Feb 24, 2022

Signed-off-by: Brendan Dougherty brendan.dougherty@shopify.com

Description

Adds the enable_system_settings option to vttestserver so that it can be passed to VTGate via vtcombo.

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
@hkdsun hkdsun added Component: vttestserver Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Feb 24, 2022
@deepthi deepthi requested a review from vmg February 24, 2022 17:10
@frouioui frouioui merged commit 242beb3 into vitessio:main Feb 25, 2022
@frouioui
Copy link
Member

Thank you for your contribution @brendar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: vttestserver Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants