evalengine: more comprehensive type coverage #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmg
added
Type: Internal Cleanup
release notes none
Component: Evalengine
Signed-off-by: Vicent Marti <vmg@strn.cat>
vmg
force-pushed
the
evalengine-typecover
branch
from
b056bcf
to
08e1a14
Compare
mattlord
approved these changes
Mar 1, 2022
| @@ -339,16 +371,16 @@ func (er *EvalResult) makeTextualAndConvert(collation collations.ID) bool { | |||
| } | |||
|
|
|||
| func (er *EvalResult) truncate(size int) { | |||
There was a problem hiding this comment.
nit but IMO the function should be called ~ enforceSize since we truncate or pad as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we've started using the evaluation engine for VDiff, @mattlord has found several issues where our type coverage was not good enough and we were failing to operate on types that were (in theory) supported but that we failed to handle because our type checks where too constricted (e.g.
TEXTvsCHARvsVARCHAR).This PR attempts to fix any further cases that may come up in the future by switching the
evalengineto using thesqltypes.IsXXXcategory checks instead of explicitly comparing against specific types. It also cleans up some technical debt by renaming some helper methods which were IMO a bit confusing.Related Issue(s)
Checklist
Deployment Notes