Revert "fix(browser): don't inject empty process global (#6213)"

This reverts commit 1affb99.
vitest-dev · Jul 24, 2024 · 9069bdc · 9069bdc
1 parent b76a927
commit 9069bdc
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 30 deletions.
diff --git a/packages/browser/rollup.config.js b/packages/browser/rollup.config.js
@@ -114,18 +114,17 @@ export default () =>
         }),
       ],
     },
-    // Should be built only when we update the jest-dom package
-    // {
-    //   input: './src/client/tester/jest-dom.ts',
-    //   output: {
-    //     file: './jest-dom.d.ts',
-    //     format: 'esm',
-    //   },
-    //   external: [],
-    //   plugins: [
-    //     dts({
-    //       respectExternal: true,
-    //     }),
-    //   ],
-    // },
+    {
+      input: './src/client/tester/jest-dom.ts',
+      output: {
+        file: './jest-dom.d.ts',
+        format: 'esm',
+      },
+      external: [],
+      plugins: [
+        dts({
+          respectExternal: true,
+        }),
+      ],
+    },
   ])
diff --git a/packages/browser/src/node/plugin.ts b/packages/browser/src/node/plugin.ts
@@ -167,6 +167,7 @@ export default (browserServer: BrowserServer, base = '/'): Plugin[] => {
         const define: Record<string, string> = {}
         for (const env in (project.config.env || {})) {
           const stringValue = JSON.stringify(project.config.env[env])
+          define[`process.env.${env}`] = stringValue
           define[`import.meta.env.${env}`] = stringValue
         }
 
@@ -333,20 +334,21 @@ export default (browserServer: BrowserServer, base = '/'): Plugin[] => {
       name: 'vitest:browser:support-testing-library',
       config() {
         return {
+          define: {
+            // testing-library/preact
+            'process.env.PTL_SKIP_AUTO_CLEANUP': !!process.env.PTL_SKIP_AUTO_CLEANUP,
+            // testing-library/react
+            'process.env.RTL_SKIP_AUTO_CLEANUP': !!process.env.RTL_SKIP_AUTO_CLEANUP,
+            'process.env?.RTL_SKIP_AUTO_CLEANUP': !!process.env.RTL_SKIP_AUTO_CLEANUP,
+            // testing-library/svelte, testing-library/solid
+            'process.env.STL_SKIP_AUTO_CLEANUP': !!process.env.STL_SKIP_AUTO_CLEANUP,
+            // testing-library/vue
+            'process.env.VTL_SKIP_AUTO_CLEANUP': !!process.env.VTL_SKIP_AUTO_CLEANUP,
+            // dom.debug()
+            'process.env.DEBUG_PRINT_LIMIT': process.env.DEBUG_PRINT_LIMIT || 7000,
+          },
           optimizeDeps: {
             esbuildOptions: {
-              define: {
-                // testing-library/preact
-                'process.env.PTL_SKIP_AUTO_CLEANUP': JSON.stringify(!!process.env.PTL_SKIP_AUTO_CLEANUP),
-                // testing-library/react
-                'process.env.RTL_SKIP_AUTO_CLEANUP': JSON.stringify(!!process.env.RTL_SKIP_AUTO_CLEANUP),
-                // testing-library/svelte, testing-library/solid
-                'process.env.STL_SKIP_AUTO_CLEANUP': JSON.stringify(!!process.env.STL_SKIP_AUTO_CLEANUP),
-                // testing-library/vue
-                'process.env.VTL_SKIP_AUTO_CLEANUP': JSON.stringify(!!process.env.VTL_SKIP_AUTO_CLEANUP),
-                // dom.debug()
-                'process.env.DEBUG_PRINT_LIMIT': process.env.DEBUG_PRINT_LIMIT || '7000',
-              },
               plugins: [
                 {
                   name: 'test-utils-rewrite',

diff --git a/test/browser/test/another.test.ts b/test/browser/test/another.test.ts
@@ -3,7 +3,3 @@ import { expect, it } from 'vitest'
 it('basic 3', async () => {
   expect(globalThis.window).toBeDefined()
 })
-
-it('no process', () => {
-  expect(globalThis.process).toBeUndefined()
-})