Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitest fails when using vite-plugin-ruby #436

Closed
6 tasks done
timgoeller opened this issue Jan 4, 2022 · 2 comments · Fixed by #438
Closed
6 tasks done

Vitest fails when using vite-plugin-ruby #436

timgoeller opened this issue Jan 4, 2022 · 2 comments · Fixed by #438

Comments

@timgoeller
Copy link

Describe the bug

Based on this issue in the vite-plugin-ruby repo: ElMassimo/vite_ruby#170

When using vite-plugin-ruby, the execution of Vue Component Tests does not work. It fails with Error: failed to load /vite-development/@vite/client. @ElMassimo mentioned, that it is probably related to the use of base (ElMassimo/vite_ruby#170 (comment)).

Reproduction

https://stackblitz.com/edit/node-sr8dj2?file=vite.config.js

System Info

System:
    OS: macOS 11.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 79.82 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.asdf/installs/nodejs/16.13.1/bin/node
    Yarn: 1.22.17 - ~/.asdf/installs/nodejs/16.13.1/.npm/bin/yarn
    npm: 8.1.2 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Chrome: 96.0.4664.110
    Firefox: 95.0.2
    Safari: 14.1.1
    Safari Technology Preview: 14.2
  npmPackages:
    @vitejs/plugin-vue: ^2.0.1 => 2.0.1 
    vite: ^2.7.0 => 2.7.10 
    vitest: ^0.0.131 => 0.0.131

Used Package Manager

yarn

Validations

@sheremet-va
Copy link
Member

The reproduction you provided fails with other error. I also downloaded your repo and it doesn't fail at all.

Did you mean to issue this error: Cannot read properties of undefined (reading 'userAgent')?

@timgoeller
Copy link
Author

@sheremet-va My bad, the repo worked because publicOutputDir in vite.json was set to "" to check if the issue actually has something to do with base. I've changed it to values one would actually use, and it should fail now.

The message Cannot read properties of undefined (reading 'userAgent') is the desired state on stackblitz, since it shows the test ran.

@antfu antfu closed this as completed in #438 Jan 4, 2022
chaii3 pushed a commit to chaii3/vitest that referenced this issue May 13, 2022
* feat(useTransition): support for vectors (vitest-dev#376)

* refactor(useTransition): cleaning up (vitest-dev#385)

* refactor(useWebWorkerFn): Small doc and type improvements (vitest-dev#382)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* feat: pwa reload prompt

* chore: update docs

* refactor(useWebWorkerFn): Small doc and type improvements (vitest-dev#382)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* chore: update docs

* test: simpilfy tests for useTransition

* chore: fix tests

* feat(useTransition): support for delayed transitions (vitest-dev#386)

* feat(useTransition): support for disabled transitions (vitest-dev#436)

* feat!: introduce `controls` option

* chore: update

* chore: update

* refactor(useRafFn): remove depreacted APIs

* chore: enabled tests for next branch

* fix(useFetch)!: allow setting response type before doing request (vitest-dev#454)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* chore: resolve conflicts

* feat(useMediaControls): expose source types (vitest-dev#495)

* fix(useMediaControls): Removes tracks that have been inserted in html (vitest-dev#493)

* chore: release v4.9.3

* fix(usePermission): tolerate error on FireFox

* fix(useDevicesList): treat as premssion granted after getUserMedia

* chore: release v4.9.4

* chore: fix typo (vitest-dev#502)

* feat(useWebSocket): add immediate option (vitest-dev#503)

* feat(useAxios): bring API into line with useFetch (vitest-dev#499)

* feat(createEventHook): new function (#497)

* chore: release v4.10.0

* fix(useMediaControls): Doesn't rewrite default media properties (vitest-dev#500)

* feat(useMediaControls): add error event (vitest-dev#509)

* feat(useStorage): optimize event handling logic (vitest-dev#505)

* feat(useFetch): add afterFetch option, onFetchResponse, and onFetchError (vitest-dev#506)

* feat(useWebWoker): return worker (vitest-dev#507)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* fix: Change `onMediaError` to `onSourceError` (vitest-dev#510)

* feat(onClickOutside): default to just pointerDown (vitest-dev#508)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Co-authored-by: sibbng <sibbngheid@gmail.com>

* chore: update docs

* chore: release v4.11.0

* fix(onClickOutside): duplicate code (vitest-dev#519)

Co-authored-by: Nurettin Kaya <sibbngheid@gmail.com>

* feat(createEventHook): added interface (vitest-dev#531)

* feat(createEventHook): added interface

* added types for EventHookOn, EventHookOff, and EventHook trigger

* feat(useStorage): allow custom serializer (vitest-dev#528)

* feat(useStorage): allow custom serializer

* update test

* refactor(useMediaControls): Deprecate options that can simply be set as attributes (vitest-dev#514)

* useMediaControls: Add `volumechange` event listener

* fix: `mute` returned

* feat: Deprecate video options:
* `poster`
* `autoplay`
* `preload`
* `loop`
* `controls`
* `playsinline`
* `autoPictureInPicture`

* fix: Fix deprecated behaviour in demo

* fix: Remove deprecated usage from doc

* refactor: More polite messages

* fix: Remove `console.warn`s

* chore: release v4.11.1

* refactor!: remove deprecated apis

* chore: add next tag

* chore: release v5.0.0-beta.1

* feat: introduce `components` & `directives` (vitest-dev#486)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* docs: re-organize

* chore: fix lint

* docs: about components

* chore: include directives

* chore: release v5.0.0-beta.2

* chore: rollback jest

* chore: fix docs build

* docs: readme for components

* docs: add @vueuse/gesture

* chore: ship indexes.json

* chore: release v5.0.0-beta.3

* feat(typedef): add return typedefs (vitest-dev#543) (vitest-dev#544)

* refactor!: change publish strcture and support submodules, close vitest-dev#469

* chore: cleanup stories.tsx

* docs: update docs about submodules

* chore: fix docs

* chore: release v5.0.0-beta.4

* chore: update lock

* chore: release v5.0.0-beta.5

* chore: update deps and extend publish memory

* refactor: remove `useDeviceLight`

* chore: update

* chore: fix tests

* chore: release v5.0.0-beta.7

* refactor(useWebSocket)!: change immediate default for 5.0.0 (vitest-dev#545)

* feat(useIpcRenderer): new add-one & new functions (vitest-dev#547)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>

* chore: update deps

* chore: release v5.0.0-beta.8

* chore: fix docs build

* chore(usePointerSwipe): fix typo (vitest-dev#557)

* fix(useAuth): now reqiures the auth instance, close vitest-dev#538

* chore: update deps

* docs(biSyncRef): fix console output comment (vitest-dev#555)

* docs: removed deprecated value from example (vitest-dev#556)

* docs(guidlines): added guidelines (vitest-dev#535)

* docs: update guidelines

* chore: update guidelines

Co-authored-by: Scott Bedard <scottbedard@users.noreply.github.com>
Co-authored-by: Fabian <donskelle@googlemail.com>
Co-authored-by: Ismail Gjevori <isgjevori@protonmail.com>
Co-authored-by: Alex Kozack <cawa-93@users.noreply.github.com>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: wheat <jacobrclevenger@gmail.com>
Co-authored-by: sibbng <sibbngheid@gmail.com>
Co-authored-by: JserWang <jserwang@gmail.com>
Co-authored-by: Pig Fang <g-plane@hotmail.com>
Co-authored-by: ArcherGu <34826812+ArcherGu@users.noreply.github.com>
Co-authored-by: Ilya Komichev <hello@ilko.me>
Co-authored-by: Daiki Ojima <daiking.ca2@gmail.com>
Co-authored-by: Manaus <manaustransez@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants