Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to fail on only #668

Closed
4 tasks done
DerYeger opened this issue Feb 2, 2022 · 0 comments · Fixed by #669
Closed
4 tasks done

feat: add option to fail on only #668

DerYeger opened this issue Feb 2, 2022 · 0 comments · Fixed by #669
Assignees
Labels
enhancement New feature or request

Comments

@DerYeger
Copy link
Member

DerYeger commented Feb 2, 2022

Clear and concise description of the problem

Sometimes an unwanted only used for writing tests may sneak into a commit.
If this isn't caught in the review process, potentially failing tests could be skipped by accident.

Suggested solution

Add an option --fail-on-only (or similar name) to fail a file if it contains an only test or suite.

I'd be happy to work on this if it's a desired feature.

Alternative

No response

Additional context

No response

Validations

@DerYeger DerYeger added the enhancement New feature or request label Feb 2, 2022
@DerYeger DerYeger self-assigned this Feb 2, 2022
@antfu antfu closed this as completed in #669 Feb 3, 2022
chaii3 pushed a commit to chaii3/vitest that referenced this issue May 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant