Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix contrast between lang name and code block #1996

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

kingyue737
Copy link
Contributor

fix #1994 by darkening --vp-c-text-dark-3

It seems that only lang name and code line number (which does not exist in vitest docs) are affected by --vp-c-text-dark-3 in light mode.

https://github.com/vuejs/vitepress/blob/b1511cf7b702a72b8fc79ff8190f9ae3c8fae2de/src/client/theme-default/styles/vars.css#L209

https://github.com/vuejs/vitepress/blob/b1511cf7b702a72b8fc79ff8190f9ae3c8fae2de/src/client/theme-default/styles/components/vp-doc.css#L415

Now in light mode:
image

@antfu antfu merged commit 08feae1 into vitest-dev:main Sep 7, 2022
@kingyue737 kingyue737 deleted the patch-1 branch September 7, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] 'lang' in code block disappears in light mode
2 participants