Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bench): rank sorting, fix #2006 #2007

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Conversation

nickmccurdy
Copy link
Contributor

@nickmccurdy nickmccurdy commented Sep 8, 2022

Since the fastest benchmark has a rank of 1, we should be sorting in ascending, not descending, order.

@antfu antfu changed the title fix: fastest/slowest benchmark labels (fix #2006) fix(bench): rank sorting, fix #2006 Sep 10, 2022
@antfu antfu merged commit def8a77 into vitest-dev:main Sep 10, 2022
@nickmccurdy nickmccurdy deleted the fix-2006 branch September 10, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants