Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new team members #2715

Merged
merged 12 commits into from Jan 30, 2023
Merged

docs: add new team members #2715

merged 12 commits into from Jan 30, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 19, 2023 •
edited

This PR includes 2 new team members:

  • fix missing type from pwa module
  • simplify core team type
  • Vitest webtoo.ls on social links (nav bar)
  • Mastodon links for some folks
  • Discord and YouTube social links for Anthony

/cc @poyoho @AriPerkkio can you review your data?

  • Ari: can you tell me a small description and if twitter account is ok?
  • poyoho: check your name and the description

I'll check if we can also include another social entries, IIRC there is something on VitePress to do this...

AriPerkkio
AriPerkkio reviewed Jan 19, 2023
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! By the way when trying this locally, I got HTTP429 rate limit hit from Github. It seems the avatars are requested on every HMR.

docs/.vitepress/contributors.ts Outdated
Comment on lines 119 to 120
title: 'Core team member of Vitest, working',
org: 'Cloudamite',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'Core team member of Vitest, working',
org: 'Cloudamite',
title: 'A fullstack developer, working',
org: 'Cloudamite',
desc: 'Core team member of Vitest',

docs/.vitepress/contributors.ts Outdated
avatar: contributorsAvatars.AriPerkkio,
name: 'Ari Perkkiö',
github: 'AriPerkkio',
twitter: '@perkkio_ari',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually have twitter or any other similar platforms at all. Just Github and email. 🙃

The typings and logic seem to require some refactoring to make this field optional.

Suggested change
twitter: '@perkkio_ari',

@userquin
chore: use vitepress types for social links
778b912 
chore: include mastodon and org links
@userquin
Copy link
Member Author

Cool, thanks! By the way when trying this locally, I got HTTP429 rate limit hit from Github. It seems the avatars are requested on every HMR.

It is no yet official, I missunderstood a message...

Unzip public.zip inside docs/public folder, then run nr docs or pnpm docs: you can also test it using nr docs:https-no-prefetch or pnpm docs:https-no-prefetch. Open https://localhost in private window, the PWA will be removed once you close the private browsing window.

public.zip

Demivan
Demivan reviewed Jan 19, 2023
View reviewed changes
docs/.vitepress/contributors.ts Outdated
@@ -83,6 +99,7 @@ const plainTeamMembers: CoreTeam[] = [
avatar: contributorsAvatars.Demivan,
name: 'Ivan Demchuk',
github: 'Demivan',
fosstodon: 'demivan',
twitter: 'IvanDemchuk',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop it, while you are at it. I have deleted my twitter account.

Suggested change
twitter: 'IvanDemchuk',

@userquin
Copy link
Member Author

@antfu @patak-dev review NuxtLabs and StackBlitz links...

antfu
antfu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My part is good, thanks!

@userquin userquin requested a review from zxch3n January 19, 2023 21:52
@userquin
Copy link
Member Author

userquin commented Jan 19, 2023 •
edited

@zxch3n can you check your mastodon link (avatar seems match with twitter)?

EDIT: confirmed, same gh link in your profile

@userquin
Copy link
Member Author

the preview can be found here: https://deploy-preview-2715--vitest-dev.netlify.app/

@zxch3n zxch3n marked this pull request as ready for review January 22, 2023 08:47
@userquin userquin changed the title docs: add new core team members docs: add new team members Jan 23, 2023
@antfu antfu merged commit b666506 into main Jan 30, 2023
@antfu antfu deleted the userquin/docs-add-new-core-team-members branch January 30, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demivan Demivan Demivan left review comments

@antfu antfu antfu approved these changes

@AriPerkkio AriPerkkio AriPerkkio left review comments

@zxch3n zxch3n zxch3n approved these changes

@poyoho poyoho poyoho approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@userquin @Demivan @antfu @AriPerkkio @zxch3n @poyoho