Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extension option for coverage #516

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

cexbrayat
Copy link
Contributor

c8 v7.11.0 introduced an extension option, allowing to specify extensions that aren't covered by default (default are defined via https://github.com/istanbuljs/schema/blob/master/default-extension.js). It's currently possible to use with an explicit cast in vite.config.ts but exposing it would remove the need for this workaround.

See bcoe/c8@ff01cd8

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: d11c33a

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61e031a89f79990007b8595c

😎 Browse the preview: https://deploy-preview-516--vitest-dev.netlify.app

@antfu
Copy link
Member

antfu commented Jan 13, 2022

We could include known components extensions by default vue, svelte, tsx, jsx

@cexbrayat
Copy link
Contributor Author

Sure, I can open a separate PR to add smarter defaults 👍. But I think it's still handy to allow the extension option?

@cexbrayat
Copy link
Contributor Author

@antfu See #518 for smarter defaults

c8 v7.11.0 introduced an `extension` option, allowing to specify extensions that aren't covered by default (default are defined via https://github.com/istanbuljs/schema/blob/master/default-extension.js).
@antfu antfu merged commit 312808c into vitest-dev:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants