Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): delegate snapshot options to workspace from root config #5199

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 14, 2024

Description

Since SnapshotManager is a singleton managed by main Vitest instance, I think WorkspaceProject.getSerializableConfig needs to use the same options as:

this.snapshot = new SnapshotManager({ ...resolved.snapshotOptions })

I expect snapshot options to do something similar to coverage options, which is also root config only options:

coverage: this.ctx.config.coverage,

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit cad955b
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65cc559dda3d7a00089f1607

@hi-ogawa hi-ogawa marked this pull request as ready for review February 14, 2024 05:54
@hi-ogawa
Copy link
Contributor Author

Just in case, one more note: this change doesn't affect snapshot update during watch mode ("u" command) since configOverride still overrides in getSerializableConfig:

}, this.ctx.configOverride || {} as any) as ResolvedConfig

I also manually verified "u" command still works.

@sheremet-va sheremet-va merged commit 86297d4 into vitest-dev:main Feb 16, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest run --update doesn't work for workspaces
2 participants