Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Tests found #342

Closed
4 tasks done
PhilippSalvisberg opened this issue Apr 15, 2024 · 4 comments
Closed
4 tasks done

No Tests found #342

PhilippSalvisberg opened this issue Apr 15, 2024 · 4 comments

Comments

@PhilippSalvisberg
Copy link

Describe the bug

In Version 0.4.1 of the extensions the tests are found. But when I upgrade to version 0.6.0 no tests are found. Running tests via command line works.

Might be related to #285. However, Tests are found via command line only not shown in the UI of the VS Code extension.

Reproduction

  1. Clone https://github.com/PhilippSalvisberg/js23c
  2. Open sandbox2 folder this project
  3. With version 0.4.1 tests are found with version 0.6.0 no tests are found

Output

Empty output channel. Nothing to show.

Version

0.6.0

Validations

@sheremet-va
Copy link
Member

  1. The extension requires Vitest 1.5.0 - https://github.com/vitest-dev/vscode#requirements
  2. Currently, you need to have a config file for the extension to kick in - https://github.com/vitest-dev/vscode#why-is-the-extension-not-activated

PhilippSalvisberg added a commit to PhilippSalvisberg/js23c that referenced this issue Apr 15, 2024
@PhilippSalvisberg
Copy link
Author

Thanks @sheremet-va . I've updated the dependencies to 1.5.0 and created a vitest.config.ts. Now the VS Code Extension detects the tests.

@ffMathy
Copy link
Collaborator

ffMathy commented Apr 15, 2024

Could we perhaps want to create more user-friendly messages in these cases, so that people will know more intuitively? I feel like this case could happen a lot.

@sheremet-va
Copy link
Member

Could we perhaps want to create more user-friendly messages in these cases, so that people will know more intuitively? I feel like this case could happen a lot.

If we could detect this scenario, then we would just start Vitest. The problem is that the extension activates only if there is a config file now:

"activationEvents": [

If you have a solution in mind, PR is welcome. Ideally, we should detect these tests.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants