Add basic coverage code lens support [issue-136] #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uioporqwerty
commented
Mar 2, 2024
src/runHandler.ts
Outdated
| @@ -76,6 +76,8 @@ export async function runHandler( | |||
|
|
|||
| run.end() | |||
| log.info('Tests run end') | |||
|
|
|||
| await vscode.commands.executeCommand('editor.action.refreshCodeLens'); | |||
There was a problem hiding this comment.
We will refresh all the code lens here after the test so ensure they have up to date coverage information
hi-ogawa
reviewed
Mar 5, 2024
| @@ -0,0 +1,92 @@ | |||
| import * as vscode from 'vscode'; | |||
| import * as fs from 'fs' | |||
| import { describe, expect, it, vi, beforeEach, afterEach } from 'vitest' | |||
There was a problem hiding this comment.
Tests are now executed by https://github.com/microsoft/vscode-test-cli with mocha, so I didn't think this would work. Did you run pnpm test?
|
The extension was rewritten from the ground up in #253. Feel free to reimplement this feature in a separate PR. It should be a bit easier because we have direct access to the coverage, and we don't need to read it from the reporter file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a code lens similar to jest as documented here: #136 (comment)
Current assumptions:
jsonas their reporter.Improvements and gutter support to follow, but this is a good first step I think. Feedback welcome :)