New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map crashes #34
Comments
Merged all map crashes issues onto this one |
I also get a crash on TNT map02 when going turning right at the end of the stairs that lead outside. |
So it even crashes on build 0.1? Wow that's a very very early release. Can you try with DosBox-X to see if it catches better the exception? |
This commit seems to be the culprit |
I was trying to play back TNTmax.LMP movie by Never_Again with this revert, it seems to play back much further. I still got a crash in a late map but not map02 |
Uhhh very interesting, wasn't expecting a bug due to a Lee Killough optimization. I'm going to try also if it affects any of the other map crashes reports. Differences tested:
So I guess is safe to revert cd47382, maybe memmove is buggy on OpenWatcom but not on DJGPP. |
This early commit causes crashes on maps E4M3, E4M9 and Plutonia MAP12 (#34) I'm pretty sure this issue due to a buggy memmove function on OpenWatcom, but will look onto it.
Well I see those implementations in the open watcom source tree: https://github.com/open-watcom/open-watcom-v2/blob/047386398d3b538c8ba9792714e6143b1f44f0ca/bld/clib/memory/c/memmove.c not sure which one gets used in the end. |
Actually I still get a crash on pluutonia map 12 and this even happens with the original PCDOOM-v2 so it is not your fault. and thus maybe do look at what chocolate-doom did: EDIT: No it is not visplane overflow ignore this plutonia behaves fine under vanilla anyway... |
Sorry for noizy information, I made a mistake and actually I get no crash with PCDoom-v2-master branch. |
Plutonia Map12 insta-crash for me started with 7f22fcb To fix it I just replaced:
Now |
Actually the patch I did was:
I guess that this is treating a symptom and the root cause must be something else. |
The patch checking for NULL mthing actually works, I was able to test MAP12 without crashes, but yeah the issue must be coming from somewhere else. Anyway I think is good to have a check for NULL objects to avoid problems. |
Well even with all those I get a crash in TNT MAP20 in some cases. I also get desync... I will investigate further |
MAP20 crashes since 34a2bed |
Looks like a precision loss error, maybe reverting it also fixes #52 |
The desync was my fault, I did not apply all fdoom patches, so now I can play back TNT map20 without problems, I can also play back the whole tntmax.lmp 4 hour movie... |
#52 is indeed fixed for me. |
Ok I revert 34a2bed until we find the edge cases that makes this commit crash in some maps/screen sizes. |
I've been testing also FreeDoom2 MAP15 and it works without issues. |
I'm also closing this as it seems all map crashes have been fixed. If we find a new crash I'll reopen it. |
The text was updated successfully, but these errors were encountered: