Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov CI and update template #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grst
Copy link

@grst grst commented Apr 14, 2023

This PR fixes some problems with the CI setup of the scverse-cookiecutter template repo. Last night, the codecov package was pulled from PyPI. This can easily be replaced, however we've realized our automatic template sync system does not allow us to modify github actions (a security precaution from github), so we need to roll out this update manually.

We're also taking this opportunity to make several other intended changes for to the CI workflow.

We're still looking into how we can avoid this in the future, which will likely require us changing how our template sync system works. This is being tracked in the scverse/cookiecutter-scverse#138.

Changes

These changes constitute the 0.2.1 release of the template and make the following changes:

Additional remarks

  • If there are merge conflicts, they either show up inline (>>>>>>>) or a .rej file will have been created for the respective files. You need to address these conflicts manually. Make sure to enable pre-commit.ci (see below) to detect such files.
  • The scverse template works best when the pre-commit.ci, readthedocs and codecov services are enabled. Make sure to activate those apps if you haven't already.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #5 (4d54c4e) into main (7d9ba3d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files           5        5           
  Lines         553      553           
=======================================
  Hits          437      437           
  Misses        116      116           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cell2module/models/_base_module.py 57.74% <100.00%> (ø)
src/cell2module/models/_cell2module_model.py 85.96% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant