Improve shebang #17
Merged
Improve shebang #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vito-c Hey, if you are too busy to review this PR, can you add me to collaborators? |
|
I will review it this week |
|
In the mean time can you provide a couple more examples of shebangs you want to work please. |
vito-c
reviewed
Aug 4, 2023
This code is copied from Any other questions about this PR? |
|
@vito-c, Hey, any other questions about this PR? If you are busy to review the PR, can you add me to collaborators? |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original shebang detect is not robust. Even
#!/usr/bin/env -S sh -c 'echo jq $0'will still be recognized to jq.Now this code is referenced from vim's code which only recognize
#!/the/path/jq,#!/the/path/env jq#!/the/path/env -S jq XXX, etc.