Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 migration #57

Merged
merged 14 commits into from
Nov 25, 2016
Merged

Python3 migration #57

merged 14 commits into from
Nov 25, 2016

Conversation

sebastian-code
Copy link
Collaborator

@sebastian-code sebastian-code commented Jun 2, 2016

I'm sorry but there is no another branch were to point this changes, I have tested almost all the functionalities and the code is working properly, but there is still room for further improvement.

The scope of this branch is to contain all the changes I make while I migrate the code base to Python3.

With this, my intent is to attend issue #49 but this is just as a consideration.

@qulc
Copy link

qulc commented Jul 22, 2016

me too, migrate to python3,

https://github.com/qulc/bootcamp

@dwayne
Copy link

dwayne commented Nov 24, 2016

@sebastian-code Are you still working on this PR? I'd be happy to contribute, what's holding this up? Do you need help?

@sebastian-code
Copy link
Collaborator Author

Hi @dwayne At this point this PR is functional up until I'm able to validate, and there is no problem I'm aware of; I would say than this is being in hold because is waiting to be approved and merged by @vitorfs.

I have to check the code to validate if there is some pending work into it, because I left the PR in it's actual state because I was waiting a response.

@vitorfs vitorfs merged commit 596481f into vitorfs:master Nov 25, 2016
@vitorfs
Copy link
Owner

vitorfs commented Nov 25, 2016

Sorry for holding it back guys!
I merged the pull request
Also added python 2 compatible decorator to the models, so to keep it working on both Python 2 and 3
I was thinking about improving the quality of the project (I developed it like 2 years ago or something)
Things on my list: isort, coverage, flake8, tox to run tests on both python 2 and 3, and start adding some unity tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants