Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvement #66

Closed
18 of 21 tasks
sebastian-code opened this issue Nov 26, 2016 · 11 comments
Closed
18 of 21 tasks

Further improvement #66

sebastian-code opened this issue Nov 26, 2016 · 11 comments

Comments

@sebastian-code
Copy link
Collaborator

sebastian-code commented Nov 26, 2016

Following the suggestions by @vitorfs and questions by @dwayne on #57 I wanted to set a list of potential improvements:

On the next list I would define some additional requests, perhaps too old and somehow relegated to the nice to have drawer:

Do you both have additional suggestions, requests or goals? As an example, badges are really nice, but there is no need to have all of them, do you have some ideas about which badges the project should have?

PD 4-12-16: Updating the list to include requirements monitoring and the proper badge.
PD 18-12-16: Updating the list to include the reputation system.
PD 13-05-17: Updating the list to include the requirement to add testing to apps.
PD 3-7-17: Updating the issue to add a list of nice to have and forgotten requests.

@sebastian-code
Copy link
Collaborator Author

I'm honored @vitorfs for the invitation to collaborate.

@sebastian-code
Copy link
Collaborator Author

Hi @vitorfs I was trying to add requires.io to keep track of the requirements of the project. I'm not allowed to do it, but I would guess you can, so here is where we should think if that is a nice feature and useful somehow.

I would think than now I'm having a change of heart just because of frustration because I wasn't able to do it, but I would love to hear your opinion.

@vitorfs
Copy link
Owner

vitorfs commented Dec 5, 2016

hey @sebastian-code! I really appreciate all the effort and your contributions to the project! :-)
I've added the requires.io badge in the README.md
We have some outdated requirements, but from what I've seen they are all easy to upgrate

@sebastian-code
Copy link
Collaborator Author

Hi @vitorfs and thanks for your compliments; it's my pleasure. I have been going around a little bit, but the requirements are already met, right now I finished implementing the Flake8 error report, is already in my development branch and I'm validating than everything works, which is how it looks as far as I can see.

@sebastian-code
Copy link
Collaborator Author

Updating after running Flake8 and applying the suggested changes. Do you mind to test it a little bit to see how it went?

@sebastian-code
Copy link
Collaborator Author

Ufff, docker implemented. I was believing it wasn't going to work. Silly me.

@sebastian-code sebastian-code added this to the v1.0.0 milestone Jul 3, 2017
sebastian-code added a commit that referenced this issue Jul 26, 2017
…all the functionalities to attend the issues #54, #66, #73 and #74 by users like @unsystemizer and @sebastian-code. Also includes some new CBV to replace some cluttered code as suggested in #66.
sebastian-code added a commit that referenced this issue Aug 26, 2017
…ost recent changes, mainly to address in a minor way #47, #66 and #105. Now the UI has a slightly different aspect, but the UX remains.

I'll work on it in the future, adding things like django-channels support for a better realtime/asynchronous workflow.
I guess I'll have to learn how to do it.
@chetanya-shrimali
Copy link
Contributor

Hey, @sebastian-code is anyone still working on this " Display the list of users who liked a given feed, on hover (As requested on #21)". cuz I would like to send pr on this issue.

@sebastian-code
Copy link
Collaborator Author

Hi @chetanya-shrimali No than I'm aware of. I'll be delighted if you send one.

@norsec
Copy link

norsec commented Oct 18, 2017

hi, i got a Social Auth System working with AllAuth Django, but was have to install the admin site to configure that. maybe we can include here?

@Allan-Nava
Copy link

I have included the admin panel with jet @norsec !
Badges are very interesting features!

sebastian-code added a commit that referenced this issue Jan 20, 2018
sebastian-code added a commit that referenced this issue Feb 14, 2018
…olves #21 and checks a pending item in #66. Still work to do, but is a nice feature.
@sebastian-code
Copy link
Collaborator Author

Milestone reached, closing this issue.

@sebastian-code sebastian-code moved this from In Progress to Done in Bootcamp Corporate Social Network Feb 17, 2018
sebastian-code added a commit that referenced this issue Jul 4, 2018
…all the functionalities to attend the issues #54, #66, #73 and #74 by users like @unsystemizer and @sebastian-code. Also includes some new CBV to replace some cluttered code as suggested in #66.
sebastian-code added a commit that referenced this issue Jul 4, 2018
…ost recent changes, mainly to address in a minor way #47, #66 and #105. Now the UI has a slightly different aspect, but the UX remains.

I'll work on it in the future, adding things like django-channels support for a better realtime/asynchronous workflow.
I guess I'll have to learn how to do it.
sebastian-code added a commit that referenced this issue Jul 4, 2018
sebastian-code added a commit that referenced this issue Jul 4, 2018
…olves #21 and checks a pending item in #66. Still work to do, but is a nice feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants