Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short Films not working any more? #39

Closed
gbstan opened this issue Sep 1, 2017 · 13 comments
Closed

Short Films not working any more? #39

gbstan opened this issue Sep 1, 2017 · 13 comments

Comments

@gbstan
Copy link

gbstan commented Sep 1, 2017

Hi Vitor,

Recently I have noticed that short films is not working for me anymore. I have the latest version of short films and also the latest versions of youtube-dl and mpv from brew (brew directly, not brew cask).

When a short film is selected in Alfred mpv opens briefly and then closes. I have the impression that the issue comes from youtube-dl somehow not passing information properly to mpv internally. Note that when I execute on the command line:

open -a mpv youtube_address

this works perfectly.

Any idea how to fix this?
Do you have the same issue with the latest versions of your installed brews (youtube-dl, mpv)?

Guy

@gbstan
Copy link
Author

gbstan commented Sep 1, 2017

I have looked into this a bit more. When I copy the link of any of the short films from invoking shorts and pressing CTRL+ENTER, and then launch in a terminal mpv link_address, this is what I get:

mpv https://player.vimeo.com/video/150608819
Playing: https://player.vimeo.com/video/150608819
[ytdl_hook]
[ytdl_hook] stack traceback:
[ytdl_hook] [C]: in function 'len'
[ytdl_hook] @ytdl_hook.lua:71: in function 'edl_escape'
[ytdl_hook] @ytdl_hook.lua:139: in function 'edl_track_joined'
[ytdl_hook] @ytdl_hook.lua:171: in function 'add_single_video'
[ytdl_hook] @ytdl_hook.lua:454: in function 'fn'
[ytdl_hook] mp.defaults:518: in function 'handler'
[ytdl_hook] mp.defaults:339: in function 'handler'
[ytdl_hook] mp.defaults:458: in function 'call_event_handlers'
[ytdl_hook] mp.defaults:495: in function 'dispatch_events'
[ytdl_hook] mp.defaults:451: in function mp.defaults:450
[ytdl_hook] [C]: in ?
[ytdl_hook] [C]: in ?
[ytdl_hook] Lua error: @ytdl_hook.lua:71: bad argument #1 to 'len' (string expected, got nil)
Failed to recognize file format.

Exiting... (Errors when loading file)

@gbstan
Copy link
Author

gbstan commented Sep 1, 2017

Seems to be linked to this issue with youtube-dl for the moment: mpv-player/mpv#4728 (comment)

@vitorgalvao
Copy link
Owner

My setup is the same as yours, and I had noticed this problem before and also found that issue from mpv’s repo. As you’ve noticed, the issue is not related to the Workflow, so there’s not much I can do to fix it.

Videos from the website ShortFilms queries are mostly vimeo, and I also cannot get mpv {{vimeo_link}} to work, so we’ll need to wait for them to fix it, unfortunately. It’s a bit of a pain, since even the HEAD version of mpv seems to not have fixed it yet.

In the meantime what I’ve been doing is on the videos, to download with DownVid and then play with WatchList.

@gbstan
Copy link
Author

gbstan commented Sep 1, 2017 via email

@vitorgalvao
Copy link
Owner

Forgot to mention before: thank you for the detailed bug report!

@gbstan
Copy link
Author

gbstan commented Sep 1, 2017 via email

@gbstan
Copy link
Author

gbstan commented Sep 2, 2017 via email

@gbstan
Copy link
Author

gbstan commented Sep 2, 2017 via email

@gbstan
Copy link
Author

gbstan commented Sep 2, 2017 via email

@mc4man
Copy link

mc4man commented Sep 2, 2017

If you were to be using the latest youtube-dl there is no issue with mpv
(- certainly any youtube-dl from 2017.08.23 on..

@gbstan
Copy link
Author

gbstan commented Sep 2, 2017 via email

@gbstan
Copy link
Author

gbstan commented Sep 2, 2017

Just to be clear and complete, I have the latest version of youtube-dl installed: 2017.09.02

@vitorgalvao
Copy link
Owner

Fixed in mpv-player/mpv@d280b3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants