Data Model Clarification & Clear Deprecation of QueryComponent #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding updates to all implementing classes. This should reduce confusion between frontend naming (where a QueryContainer corresponds to a StagedSimilarityQuery) and backend naming, where a QueryContainer corresponded to a QueryTerm. Additionally, removing Q_SIM from the Websocket API since it is superseded by Q_TEMPORAL and not used by any implementation anymore.
lucaro
reviewed
Oct 22, 2021
|
I understand the argument, @Spiess and I are after discussion both in favor of leaving the |
|
While it is implemented as an abstract class, I don't see why it would need to be one. What is the reasoning behind this? There is, as far as I can tell, nothing that would prevent you from actually instantiating it. It would compile and work correctly during runtime, just not containing any actual information. So it might just as well be a regular class, maybe with a protected constructor. |
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Data Model Clarification & Clear Deprecation of QueryComponent Former-commit-id: 947a071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remove confusion about the data model used by Cineast and its frontend (joint work with @Spiess)
Specifically, it does so by renaming QueryContainer to AbstractQueryTermContainer, with corresponding updates to all implementing classes. This should reduce confusion between frontend naming (where a QueryContainer corresponds to a StagedSimilarityQuery) and backend naming, where a QueryContainer corresponded to a QueryTerm.
Additionally, it removes Q_SIM from the Websocket API since it is superseded by Q_TEMPORAL and not used by any implementation anymore. Q_SIM used the legacy implementation which used QueryComponents, which are deprecated in Cineast.
Since this PR contains minor API changes, it bumps the version number to v3.3.0