Feature/clip #246
Merged
Feature/clip #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucaro
commented
Jan 13, 2022
lucaro
commented
- Added Image and Text features based on OpenAI CLIP
- refactored and reorganized some common helper logic
…s rather than only the most representative frame.
This is required since FFMpegAudioDecoder and TechnicalVideoMetadataExtractor use Math.floorDiv, which is a function only available since Java 9.
Due to popular demand.
# Conflicts: # build.gradle # cineast-core/src/main/java/org/vitrivr/cineast/core/features/VisualTextCoEmbedding.java
Spiess
reviewed
Jan 20, 2022
cineast-core/src/main/java/org/vitrivr/cineast/core/features/CLIPImage.java
Outdated
Show resolved
Hide resolved
cineast-core/src/main/java/org/vitrivr/cineast/core/features/CLIPText.java
Outdated
Show resolved
Hide resolved
|
Could this target master directly? I don't see a reason this has to target |
I guess it could, I don't really have a preference for the target. If we want to make a 'minor release' out of this, sure. |
silvanheller
approved these changes
Jan 21, 2022
Spiess
approved these changes
Jan 21, 2022
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
* Added feature modules for OpenAI CLIP * Minor refactoring of utility classes * Refactored common image preprocessing logic into helper class Co-authored-by: Silvan Heller <silvan.heller@unibas.ch> Co-authored-by: Florian Spiess <florian.spiess@unibas.ch> Former-commit-id: c2315f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.