Changed default number of threads for import command. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default number of threads for the import command to 1 down from 2 to avoid issues caused by parallelization for new or inexperienced users.
silvanheller
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default number of threads for the import command to 1 down from 2 to avoid issues caused by parallelization for new or inexperienced users.
This is necessary to avoid the issue discussed here for users unaware of the problem who might not know that an import cannot run successfully with all default settings using the current Cottontail DB version.
In addition to allowing default parameters to work around this issue, I think this is a good idea anyways, as no parallelism is the safest default value.