Rework extraction API endpoints #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A session can be started (the path to the extraction config to use is specified in the config) and ended, and objects can be queried for extraction while the session is running.
silvanheller
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken REST API endpoints for feature extraction from items.
The session concept is roughly kept, meaning that an extraction session first has to be opened before items can be added, and should be closed once all items have been added.
The path to the extraction configuration to use can be specified in the config file with
sessionExtractionConfigLocation.The
ExtractionContextProviderinterface is used inGenericExtractionItemHandlerinstead of anIngestConfigto properly reuse the handler.Since I will not have any time for further changes or contributions to this, @silvanheller asked me to open this PR as-is -- feel very free to make further changes to the respective branch.