Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of IPv6 for worker ip address #21

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Conversation

NickFitton
Copy link
Contributor

@NickFitton NickFitton commented Mar 16, 2019

Issue

Workers were failing to connect to scheduler

Cause

Workers were trying to give the scheduler an IPv6 address to callback on

Resolution

Add functionality to only allow InetAddress classes that are instances of Inet4Address

Also

  • Make some thrown exceptions less generic
  • Ignores a test that fails due to integration with Cineast not being up-to-date

Next PR

  • Make indentation 2 spaces, code cleanup

@lucaro
Copy link
Member

lucaro commented Mar 16, 2019

Is there a particular reason to reject all IPv6 addresses entirely?

@lucaro lucaro merged commit a697b33 into vitrivr:master Mar 16, 2019
@NickFitton
Copy link
Contributor Author

Is there a particular reason to reject all IPv6 addresses entirely?

The IPv6 that is returned has the port attached which the scheduler did not like.
2a02:c7f:149c:8a00:a117:1300:d051:3e9c%wlp3s0
I don't know enough about IPv6 to fix this but it could be something I can look in to later in my work

@NickFitton NickFitton deleted the bug/ivp6-use branch March 18, 2019 08:27
NickFitton added a commit to NickFitton/cthulhu that referenced this pull request Mar 18, 2019
Merge pull request vitrivr#21 from NickFitton/bug/ivp6-use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants