Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] publish action failed #64

Closed
yi-Xu-0100 opened this issue Mar 11, 2021 · 8 comments · Fixed by #71 · May be fixed by yi-Xu-0100/vscode-conventional-commits#6
Closed

[BUG] publish action failed #64

yi-Xu-0100 opened this issue Mar 11, 2021 · 8 comments · Fixed by #71 · May be fixed by yi-Xu-0100/vscode-conventional-commits#6
Assignees
Labels
help wanted Extra attention is needed

Comments

@yi-Xu-0100
Copy link
Collaborator

See https://github.com/vivaxy/vscode-conventional-commits/runs/2082721472.

Maybe I need to move the step of push commit to the publishing. 😅

Could you test this step locally for setting the env?

The good news is the v1.16.1 will not appear in release. 😀

@vivaxy
Copy link
Owner

vivaxy commented Mar 11, 2021

Sorry, I am not familiar with GitHub Actions. @yi-Xu-0100 Is there a way to test it locally?

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I revert the commit bring from the actions. 😅

- name: Publish package
env:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
run: yarn run deploy

This step is about publishing, and it runs using the bash and with the env setting.
All the steps using the run can run locally in bash. For the workflows, only the creating release can not test locally.

@vivaxy
Copy link
Owner

vivaxy commented Mar 11, 2021

I am running VSCE_PAT=MY_PERSONAL_ACCESS_TOKEN yarn deploy locally. But it prompts for Personal Access Token for publisher 'vivaxy'. I'm not sure why it's not the same error in GitHub Actions. Maybe I'll add a new test GitHub Action to test only the publish step.

@vivaxy
Copy link
Owner

vivaxy commented Mar 11, 2021

Tested to set Personal Access Token to have all access and permissions according to https://github.com/microsoft/vscode-vsce/issues/522. And Failed.

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy https://github.com/lannonbr/vsce-action I will test the cmd in this repo.

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I think it fixed! See in https://github.com/vivaxy/vscode-conventional-commits/runs/2083187479

@yi-Xu-0100
Copy link
Collaborator Author

yi-Xu-0100 commented Mar 11, 2021

@vivaxy
Copy link
Owner

vivaxy commented Mar 11, 2021

Reverted Personal Access Token scopes to only Read and Publish Marketplace.
It works fine.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment