We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug predict_win and predict_rank do not work properly on 3x3x3 games
predict_win
predict_rank
To Reproduce Step 1:
from openskill.models import PlackettLuce model = PlackettLuce() p1 = model.rating(mu=34, sigma=0.25) p2 = model.rating(mu=34, sigma=0.25) p3 = model.rating(mu=34, sigma=0.25) p4 = model.rating(mu=32, sigma=0.5) p5 = model.rating(mu=32, sigma=0.5) p6 = model.rating(mu=32, sigma=0.5) p7 = model.rating(mu=30, sigma=1) p8 = model.rating(mu=30, sigma=1) p9 = model.rating(mu=30, sigma=1) team1, team2, team3 = [p1, p2, p3], [p4, p5, p6], [p7, p8, p9] r = model.predict_win([team1, team2, team3]) print(r)
Results in: [0.439077174955099, 0.3330210112526078, 0.2279018137922932]
[0.439077174955099, 0.3330210112526078, 0.2279018137922932]
Step 2, change p9 mu to 40:
p9
40
from openskill.models import PlackettLuce model = PlackettLuce() p1 = model.rating(mu=34, sigma=0.25) p2 = model.rating(mu=34, sigma=0.25) p3 = model.rating(mu=34, sigma=0.25) p4 = model.rating(mu=32, sigma=0.5) p5 = model.rating(mu=32, sigma=0.5) p6 = model.rating(mu=32, sigma=0.5) p7 = model.rating(mu=30, sigma=1) p8 = model.rating(mu=30, sigma=1) p9 = model.rating(mu=40, sigma=1) team1, team2, team3 = [p1, p2, p3], [p4, p5, p6], [p7, p8, p9] print([team1, team2, team3]) r = model.predict_win([team1, team2, team3]) print(r)
Results are the same: [0.439077174955099, 0.3330210112526078, 0.2279018137922932]
Expected behavior After p9 mu increase team3 are expected to have a bigger chance of victory
Platform Information
Additional context https://github.com/OpenDebates/openskill.py/blob/f76df19c3e388f31050c988a0059367bd1dadc76/openskill/models/weng_lin/bradley_terry_full.py#L765
I have no idea what is going on here, and why it selects rating only of the first player, but it just does not work as intended
The text was updated successfully, but these errors were encountered:
It seems I forgot to copy over the original code before the API overhaul. Amazing how it went unnoticed for so long.
Sorry, something went wrong.
Fixed #124
061f71f
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Fixed #124 (#125)
fffdad2
* Fixed #124 Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com> * Update dependencies Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com> * Format with black Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com> * Add changelog fragment Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com> --------- Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Successfully merging a pull request may close this issue.
Describe the bug
predict_win
andpredict_rank
do not work properly on 3x3x3 gamesTo Reproduce
Step 1:
Results in:
[0.439077174955099, 0.3330210112526078, 0.2279018137922932]
Step 2, change
p9
mu to40
:Results are the same:
[0.439077174955099, 0.3330210112526078, 0.2279018137922932]
Expected behavior
After
p9
mu increase team3 are expected to have a bigger chance of victoryPlatform Information
Additional context
https://github.com/OpenDebates/openskill.py/blob/f76df19c3e388f31050c988a0059367bd1dadc76/openskill/models/weng_lin/bradley_terry_full.py#L765
I have no idea what is going on here, and why it selects rating only of the first player, but it just does not work as intended
The text was updated successfully, but these errors were encountered: