Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #124 #125

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Fixed #124 #125

merged 4 commits into from
Feb 3, 2024

Conversation

vivekjoshy
Copy link
Owner

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added test(s) covering the changes (if testable)

Issue(s) Resolved

Fixes #124

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under openskill.py's MIT license.

I certify the above statement is true and correct: @vivekjoshy

Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f76df19) 100.00% compared to head (9b18fe8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1774      1774           
  Branches       450       450           
=========================================
  Hits          1774      1774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vivekjoshy vivekjoshy added the bug Something isn't working label Feb 3, 2024
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
@vivekjoshy vivekjoshy merged commit fffdad2 into main Feb 3, 2024
48 checks passed
@vivekjoshy vivekjoshy deleted the fix-predict branch February 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predict_win and predict_rank do not work on 2x2 and more games
1 participant