Adds Scala version #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs some cleanup!
I'm aiming for valid JSON. I want to indent it properly, too..
The name is a bit of a misnomer.
…efix Protects add() because it's only to be used internally.
The import of reflectiveCalls in TrieTest is necessary to silence a warning about access theTrie in the fixture.
I cannot think of a better name for this method right now.
I cannot believe I didn't notice this before now.
I really think most of these javadocs could go away.
|
Thanks, Colin. |
|
I don't think storing the string at every node, or for that matter even at the leaf node is necessary, we can always traverse the path to find the string, so that is fine. I had changed the Python code a few months ago to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Scala version seems to work. It's at least passing tests!
One potential problem is that the Trie node itself doesn't know where it is. It just knows its value, which is None if it's not a leaf node, or Some("word") if it's a leaf. This has the advantage of storing words only in leaf nodes, but at the expense of something I'm not sure I understand well enough to miss.
I intend to generify this so that any data structure that supports head and tail can be inserted into the trie.