Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rx java 3 migration #6

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Rx java 3 migration #6

merged 2 commits into from
Mar 9, 2021

Conversation

diklimchuk
Copy link
Contributor

No description provided.

@diklimchuk
Copy link
Contributor Author

Blocked by: add backwards compatibility with RxJava2

@diklimchuk diklimchuk requested review from sergei-lapin and winstonvk and removed request for sergei-lapin March 2, 2021 17:35
sergei-lapin
sergei-lapin approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@sergei-lapin sergei-lapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some inaccuracies in readme that need to be fixed, maybe within this PR
There is wrong reference on RxJava 2 version of the artifact and in Why? section maybe we should mention RxJava 3

@diklimchuk
Copy link
Contributor Author

Thanks, fixed the readme

@diklimchuk diklimchuk merged commit 33184cf into main Mar 9, 2021
@diklimchuk diklimchuk deleted the rx-java-3-migration branch March 29, 2021 01:17
@diklimchuk diklimchuk added the enhancement New feature or request label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-lapin sergei-lapin sergei-lapin approved these changes

@winstonvk winstonvk Awaiting requested review from winstonvk

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diklimchuk @sergei-lapin