Fix validation of YouTubeVideoBlock #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdax98
force-pushed
the
fix-youtube-block-api-validation
branch
from
63388f5
to
6e9c3c7
Compare
johnnyomair
approved these changes
Jul 8, 2024
Merged
thomasdax98
added a commit
that referenced
this pull request
Jul 9, 2024
Previously, the validation of the `YouTubeVideoBlock` differed between admin and API. The admin allowed YouTube URLs and YouTube video IDs. The API only allowed URLs but blocked video IDs. Now, the API validation also accepts URLs and video IDs.
fichtnerma
pushed a commit
that referenced
this pull request
Jul 18, 2024
Previously, the validation of the `YouTubeVideoBlock` differed between admin and API. The admin allowed YouTube URLs and YouTube video IDs. The API only allowed URLs but blocked video IDs. Now, the API validation also accepts URLs and video IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the validation of the
YouTubeVideoBlockdiffered between admin and API.The admin allowed YouTube URLs and YouTube video IDs.
The API only allowed URLs but blocked video IDs.
Now, the API validation also accepts URLs and video IDs.
PR Checklist