Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symboliks tests switchup #342

Merged
merged 2 commits into from Jan 20, 2021
Merged

Symboliks tests switchup #342

merged 2 commits into from Jan 20, 2021

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Jan 20, 2021 •
edited

Old test had a ton of memory intensive passes that took a while to compute. New test is comparable but faster and cheaper.

atlas0fd00m
atlas0fd00m approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@atlas0fd00m atlas0fd00m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. minor changes, better performance, no less value.

@rakuy0 rakuy0 merged commit 5a67876 into master Jan 20, 2021
@rakuy0 rakuy0 deleted the symtest_streamline branch January 20, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlas0fd00m atlas0fd00m atlas0fd00m approved these changes

@ma77carpenter ma77carpenter ma77carpenter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rakuy0 @atlas0fd00m @ma77carpenter