Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elf checksec and stuff #379

Merged
merged 15 commits into from Mar 25, 2021
Merged

Conversation

atlas0fd00m
Copy link
Contributor

No description provided.

Copy link
Contributor

@rakuy0 rakuy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wild in here. Pair of minor questions, but nothing that blocks merging. More curious than anything else.

DF_BIND_NOW = 0x00000008
DF_STATIC_TLS = 0x00000010

df_names = { v:k for k,v in globals().items() if k.startswith('DF_')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo, what is this used for? I can't find any refs to it, and I don't know what your plans for it are.

@@ -27,7 +27,7 @@ def tearDown(self):
self.proc.stdin.flush()
self.trace.run()
try:
self.proc.wait(timeout=30)
self.proc.wait(timeout=120)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, git might complain here depending on if you merge this PR or the other one first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprisingly, it allowed me to merge in updates without complaining so far.... it'd be way cool is the unittests passed and it still allowed me to merge. will let you know.

@atlas0fd00m atlas0fd00m merged commit 2db9244 into vivisect:master Mar 25, 2021
@atlas0fd00m atlas0fd00m deleted the elf_checksec_and_stuff branch March 25, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants