New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elf checksec and stuff #379
Elf checksec and stuff #379
Conversation
* dynamic dialog box helper * actually do something with defaults, and update docstr to help. * warning and informational messages too. * bugfixes in QtCore and other imports * cleanup and additions to the README * oops, removed this prematurely. * cleanup example gui extension * Update README.md thanks @williballenthin! Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com> Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wild in here. Pair of minor questions, but nothing that blocks merging. More curious than anything else.
DF_BIND_NOW = 0x00000008 | ||
DF_STATIC_TLS = 0x00000010 | ||
|
||
df_names = { v:k for k,v in globals().items() if k.startswith('DF_')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sooo, what is this used for? I can't find any refs to it, and I don't know what your plans for it are.
vtrace/tests/__init__.py
Outdated
@@ -27,7 +27,7 @@ def tearDown(self): | |||
self.proc.stdin.flush() | |||
self.trace.run() | |||
try: | |||
self.proc.wait(timeout=30) | |||
self.proc.wait(timeout=120) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up, git might complain here depending on if you merge this PR or the other one first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprisingly, it allowed me to merge in updates without complaining so far.... it'd be way cool is the unittests passed and it still allowed me to merge. will let you know.
No description provided.