Cleanup #385
Cleanup #385
Conversation
converting from str to bytes for network comms, but leaving everything as str's otherwise.
| @@ -597,7 +597,7 @@ def applyRelocs(elf, vw, addbase=False, baseaddr=0): | |||
| vw.makeImport(rlva, "*", dmglname) | |||
| vw.setComment(rlva, name) | |||
|
|
|||
| elif rtype in (Elf.R_386_32, Elf.R_386_COPY): | |||
| elif rtype in (Elf.R_386_32, Elf.R_386_COPY, Elf.R_X86_64_TPOFF64): | |||
There was a problem hiding this comment.
Soo, since this change prompted 0 complaints in our unittests, can you give a rundown of what this changes/fixes? Am I just over thinking it and it's just silencing some errors that don't matter?
There was a problem hiding this comment.
this is just telling the ELF parser that this type of relocation is normal, and not to complain about "not handling it".
There was a problem hiding this comment.
So...we have no unit tests for the cluster code. Like at all. It might be out of scope for this PR, but if you ever find yourself in that kind of mood, could you knock some simple ones out, since you seem to be a big user of it and know how it should function?
Other than that, just a small question.
|
i've been giving unittests for clustering some thought. i have code that heavily uses it, but it's kinda my special sauce behind Icharus and LightningStrike. i'm contemplating all of that right now. i think it might make sense to wrap in something. i have to admit, with the current state of Vtrace unittests causing such issues (like i roll the dice and lean toward late-night pushes to hope the unittests pass), i'm hesitant to add something that makes use of networking. |
an ARM analysis bugfix
an ELF cleanup fix (to simply not complain so much about certain relocs)
a Cobra Cluster set of bugfixes
approve now, before this list grows! ;)