Various bugfixes mostly cli oriented #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egame. and logging of traceback for "onecmd()" exceptions (duh)
bugfix: getEndian() needs to be in IMemory, since other IMemory functions reference it. improvement: Removing non-GUI vprint() which uses logging instead of memory canvas. this is setting us up to make unittests for the CLI functions by patching in a StringMemoryCanvas and comparing the results.
…that EnviCli.vprint() wins
atlas0fd00m
commented
Oct 31, 2021
atlas0fd00m
commented
Oct 31, 2021
atlas0fd00m
commented
Nov 1, 2021
rakuy0
requested changes
Nov 2, 2021
only envi in this test... vw to come
|
i just added some unittests for your viewing pleasure. |
atlas0fd00m
commented
Nov 2, 2021
atlas0fd00m
commented
Nov 2, 2021
rakuy0
reviewed
Nov 11, 2021
…void openly broken things from upsetting users and giving them a bad taste)
rakuy0
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran into bugs while demo'ing some of the CLI commands. mostly Py3 related. one has been a bug since the GIT cutover in 2014