straggler remote gui-bugs (EASY, Before 5/15/22) #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and bugfix for clicking EFLAGS gui buttons.
# Conflicts: # vtrace/qt.py
…e... updates to follow (for easy diffing between commits)
… class and revamp "lockStepEmulator" when we're done)
# Conflicts: # envi/tests/test_memmap.py
…tually catches norets using the fmcb_Thunk() analysis hook. bugfix: redo how pointers are incremented
…few kb each run :)
…tegorized as such.
cleanup coloration of NORET
more testelf
…except macho, which is a wip)
…n for a while. bringing it into the 2020's
# Conflicts: # vivisect/tests/testvivisect.py
* workaround the msgpack setting which converts lists to tuples * compat for older Viv Remote clients with newer server
# Conflicts: # vivisect/remote/server.py # vivisect/tests/testremote.py
…re leading a session with that window.
atlas0fd00m
changed the title
…e GUI starts. we need to be able to expect each workspace has a GUID, unless it's a fresh workspace.
paradigm going forward: GUID gets assigned on the first "vw.loadFrom*" or when calling "vw.getVivGuid()".
this allows us to not create a GUID if we don't want one (ie. when loading a remote workspace, or when we are just messing around). what we're trying to avoid is multiple GUIDs in the event stream. currently, with remote workspaces we have a race condition which causes a new GUID to be generated each time we connect... and Bulk analysis doesn't actually assign one.
with this fix:
```
In [1]: metaevts = [(i,evt) for i,evt in enumerate(vw._event_list) if evt[0] == 24 and evt[1][0]=='GUID']; metaevts
Out[1]: [(61618, (24, ('GUID', '8b499ddc551a86ef04091f56160d9f72')))]
In [2]: vw.getVivGuid()
Out[2]: '8b499ddc551a86ef04091f56160d9f72'
```
|
i'm telling you, you want to approve this sooner than later.... ;) |
rakuy0
reviewed
May 17, 2022
rakuy0
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow missed these in the gui components, but got them in VivWorkspace.
someday when we wrap in GUI unittests...