Relocatable ELF Support #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rakuy0
commented
Jun 10, 2022
rakuy0
commented
- Cleanup a bunch of duplicate classes for Elf section info and whitespace/typos/general spelling
- Make relocatable ELF work. Or at least a very simple example. ELF treats certain section info slightly different when the file is marked as relocatable.
- There's relocations (like R_AMD64_32S) that while we don't support quite yet (because they induce other issues), I would like to, so I added some sizing info to the relocation type so that we could one day support them.
atlas0fd00m
requested changes
Jun 17, 2022
There was a problem hiding this comment.
love all the reduction of duplication between the different Elf32/64 classes.
i'm cringing somewhat about taking the logic out of Elf and shoving it into Vstruct. i get it... but i'm not particularly joyful about it.
i think the only thing i need to see is a comment at the duplicated constants between elf_lookup.py and vstruct.defs.elf.py
atlas0fd00m
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.