envi: do dynamic imports via importlib.import_module #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be grand to find a solution for this so we can continue to package vivisect and make it's powers easily accessible to many analysts. |
|
we're working on it, @mr-tz . :) |
atlas0fd00m
approved these changes
Mar 10, 2023
|
Thank you!
|
|
Amazing, thanks for the quick fix. Can you please provide a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This derives from the issue identified here: mandiant/capa#1342 (comment)
Basically, the existing vivisect dynamic import implementation relies on source code being present on the file system, which is not a guarantee provided by the Python import framework and breaks packages such as PyInstaller (and I'd guess vivisect cobra, too!). It appears the custom code can be trivially replaced by
importlib.import_module, which is what I'm proposing here; however, I'm not aware of any potential outside discussion between @rakuy0 and @atlas0fd00m that may have decided against this implementation.Without such a fix like this, capa and FLOSS will not be able to upgrade to vivisect v1.1.0+.