Re-enable using commands as api #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
spring-raining
requested changes
Jan 31, 2022
There was a problem hiding this comment.
@zwaldowski Thank you for the PR. This API abstraction is definitely better than the previous one! Please check this.
zwaldowski
force-pushed
the
use-as-api
branch
from
2c98e90
to
48fe41e
Compare
zwaldowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes using the named exports
buildandpreviewby other packages. For completeness, it also addsinit. A test is added for usingbuildthis way.The exports were first made available in #52. They were broken after #96, because the subcommands ran their parsing at the top level of the file. Just importing the methods would run the command parser and exit the process, ignoring the arguments passed in.
The named exports
build,preview, andinitare moved to separate files. The new files specifically don’t importcommanderso that they work with tree-shaking tools.