Skip to content

Commit

Permalink
fix: text-spacing causes text accessibility problem in output PDF
Browse files Browse the repository at this point in the history
- fix #908
  • Loading branch information
MurakamiShinyu committed Apr 27, 2022
1 parent dba8071 commit 5eb4f70
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 26 deletions.
8 changes: 2 additions & 6 deletions packages/core/src/vivliostyle/assets.ts
Expand Up @@ -1433,15 +1433,11 @@ viv-ts-open.viv-ts-trim > viv-ts-inner {
}
viv-ts-close.viv-ts-auto > viv-ts-inner,
viv-ts-close.viv-ts-trim > viv-ts-inner {
margin-inline-start: -0.5em;
position: relative;
inset-inline-start: 0.5em;
letter-spacing: -0.5em;
}
viv-ts-close.viv-hang-end > viv-ts-inner,
viv-ts-close.viv-hang-last > viv-ts-inner {
margin-inline-start: -1em;
position: relative;
inset-inline-start: 1em;
letter-spacing: -1em;
}
viv-ts-open.viv-ts-auto::before,
viv-ts-close.viv-ts-auto::after,
Expand Down
20 changes: 0 additions & 20 deletions packages/core/src/vivliostyle/text-polyfill.ts
Expand Up @@ -802,26 +802,6 @@ class TextSpacingPolyfill {
}
}
}

// Support for browsers not supporting inset-inline-start property
// https://developer.mozilla.org/en-US/docs/Web/CSS/inset-inline-start#browser_compatibility
if (innerElem.style.insetInlineStart === undefined) {
let insetInlineStart = {
"viv-ts-auto": "0.5em",
"viv-ts-trim": "0.5em",
"viv-hang-end": "1em",
"viv-hang-last": "1em",
"viv-hang-end viv-hang-hw": "0.5em",
"viv-hang-last viv-hang-hw": "0.5em",
}[outerElem.className];
if (insetInlineStart) {
if (vertical) {
innerElem.style.top = insetInlineStart;
} else {
innerElem.style.left = insetInlineStart;
}
}
}
}
}

Expand Down

0 comments on commit 5eb4f70

Please sign in to comment.