Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named page at the first page is not applied when HTML head part is big #770

Closed
MurakamiShinyu opened this issue Sep 13, 2021 · 3 comments · Fixed by #773
Closed

Named page at the first page is not applied when HTML head part is big #770

MurakamiShinyu opened this issue Sep 13, 2021 · 3 comments · Fixed by #773
Assignees
@MurakamiShinyu
Labels
bug P0 Priority 0: Emergency

Comments

@MurakamiShinyu
Copy link
Member

MurakamiShinyu commented Sep 13, 2021 •
edited
Loading

Example: https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-cover.html (Thanks @baldurbjarnason)

Test with Vivliostyle: https://vivliostyle.vercel.app/#src=https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-cover.html

I found that this problem happens when the HTML head part is big, and does not happen when the HTML head part is not so big, e.g., reduce indent in the internal stylesheet or use external stylesheet instead of the internal stylesheet.
@MurakamiShinyu MurakamiShinyu added bug P0 Priority 0: Emergency labels Sep 13, 2021
@MurakamiShinyu MurakamiShinyu self-assigned this Sep 13, 2021
@MurakamiShinyu
Copy link
Member Author

MurakamiShinyu commented Sep 13, 2021 •
edited
Loading

Similar problem with the example https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-custompage2.html

Test with Vivliostyle: https://vivliostyle.vercel.app/#src=https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-custompage2.html

The problem does not happen when reduce the size of the internal stylesheet and remove HTML comments above <h2 id="i-am-vice">I am Vice</h2>

@MurakamiShinyu
Copy link
Member Author

Same problem with the example https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-contents.html

Test with Vivliostyle: https://vivliostyle.vercel.app/#src=https://github.com/baldurbjarnason/vivliostyle-tests/blob/main/vivliostyle-test-contents.html

@MurakamiShinyu MurakamiShinyu mentioned this issue Sep 13, 2021
Open
MurakamiShinyu added a commit that referenced this issue Sep 14, 2021
@MurakamiShinyu
fix: Named page at the first page is not applied when HTML head part …
0f696dc 
…is big

Fixes #770
@MurakamiShinyu MurakamiShinyu mentioned this issue Sep 14, 2021
Merged
@MurakamiShinyu
Copy link
Member Author

Fixed in #773

Test with Vivliostyle Viewer:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MurakamiShinyu MurakamiShinyu

Labels
bug P0 Priority 0: Emergency
Projects
None yet
Milestone
No milestone
1 participant
@MurakamiShinyu