Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support no-comma CSS color functions #940

Closed
depth42 opened this issue Jun 13, 2022 · 3 comments · Fixed by #953
Closed

Support no-comma CSS color functions #940

depth42 opened this issue Jun 13, 2022 · 3 comments · Fixed by #953
Assignees
@MurakamiShinyu
Labels
feature request P1 Priority 1: Required for MVP (Minimum Viable Product) spec conformance

Comments

@depth42
Copy link

depth42 commented Jun 13, 2022

It would be nice if Vivliostyle would support the ever more popular no-comma CSS color functions for specifying color values with and without alpha channel.

They look like this: rgb(255 128 80 / 0.8)

https://www.w3.org/TR/css-color-4/#rgb-functions
@MurakamiShinyu MurakamiShinyu self-assigned this Jun 13, 2022
@MurakamiShinyu MurakamiShinyu added the P1 Priority 1: Required for MVP (Minimum Viable Product) label Jun 13, 2022
@MurakamiShinyu
Copy link
Member

@depth42 Thanks for the feature request. I recognize that the CSS parser and validation mechanism implemented in Vivliostyle (its significant part comes from the base project https://github.com/sorotokin/adaptive-layout) need to be updated to support the latest CSS standards.

MurakamiShinyu added a commit that referenced this issue Jul 13, 2022
@MurakamiShinyu
feat: Improve CSS validator to support new property values supported …
1d5f493 
…in browser

With this change, Vivliostyle.js can support new CSS property values supported in browser,
including support for new color value syntax defined in CSS Color Level 4.

- resolves #940
@MurakamiShinyu MurakamiShinyu mentioned this issue Jul 13, 2022
Merged
@MurakamiShinyu
Copy link
Member

@depth42
Please check Vivliostyle.js v2.16.0 (CLI v5.3.0) now supporting no-comma CSS color functions.

@depth42
Copy link
Author

depth42 commented Jul 21, 2022

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MurakamiShinyu MurakamiShinyu

Labels
feature request P1 Priority 1: Required for MVP (Minimum Viable Product) spec conformance
Projects
None yet
Milestone
No milestone
2 participants
@depth42 @MurakamiShinyu