Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for break-* properties #127

Merged
merged 10 commits into from Jan 7, 2016
Merged

Improve support for break-* properties #127

merged 10 commits into from Jan 7, 2016

Conversation

kwkbtr
Copy link
Contributor

@kwkbtr kwkbtr commented Jan 7, 2016

  • Issues: Appropriately handle interaction between forced break value and avoid break value #26, Update acceptable values for break-* properties #103
  • page-break-* properties are now treated as aliases for break-* properties with page break values.
  • Update acceptable values for break-* properties according to the latest CSS Fragmentation Module spec
  • Fix handling of forced and avoid break values
    • Forced break values take precedence over avoid break values and auto
  • Note that the current implementation treats all values of break-inside other than auto as the same as avoid. The fine-grained control (distinguishing avoid, avoid-page, avoid-column and avoid-region) will be a future task and tracked with a separate issue.
  • Note that though the spec requires to honor multiple break-before/break-after values at a single break point, the current implementation choose one of them and discard the others. The fine-grained control of these break values will be a future task and tracked with a separate issue.

- Plugin authors can register functions to hooks provided by the core code with `vivliostyle.plugin.registerHook` method. They can be removed by `vivliostyle.pulgin.removeHook` method.
- Types of implemented hooks are listed in `vivliostyle.plugin.HOOKS`.
  - There is currently one hook: "SIMPLE_PROPERTY". See comments in code for details.
- Spec: https://drafts.csswg.org/css-break/#break-within
- Values: auto | avoid | avoid-page | avoid-column | avoid-region
- Note that the current implementation treat all values other than `auto` as the same as `avoid`. The fine-grained control (distinguishing `avoid`, `avoid-page`, `avoid-column` and `avoid-region`) will be a future task and tracked with a separate issue.
…alues for `break-before`/`break-after` properties

- Spec: CSS Fragmentation Module
  - Forced Breaks https://drafts.csswg.org/css-break/#forced-breaks
  - Unforced Breaks https://drafts.csswg.org/css-break/#unforced-breaks
- Note that though the spec requires to honor multiple break values at a single break point, the current implementation choose one of them and discard the others. The fine-grained control of these break values will be a future task and tracked with a separate issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant