Implement UI states selectors (:checked, :enabled and :disabled)
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation simply uses attributes on the source DOM node to judge the UI state. Specifically, `:checked` matches if the element has `checked` or `selected` attribute and its value is true, and `:enabled`/`:disabled` matches if the element has `disabled` attribute and its value is false/true. The selectors do not match an element without UI states (such as a `p` element), even if it has `disabled` or `selected` content attribute, for such an element does not have `disabled` or `selected` DOM property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #197
This implementation simply uses attributes on the source DOM node to judge the UI state. Specifically,
:checkedmatches if the element hascheckedorselectedattribute and its value is true, and:enabled/:disabledmatches if the element hasdisabledattribute and its value is false/true. The selectors do not match an element without UI states (such as apelement), even if it hasdisabledorselectedcontent attribute, for such an element does not havedisabledorselectedDOM property.