Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example default triple store from SDB to TDB #144

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

awoods
Copy link
Member

@awoods awoods commented Feb 24, 2020

Resolves: https://jira.lyrasis.org/browse/VIVO-1741

What does this pull request do?

No functional changes.
This pull-request updates the example.applicationSetup.n3 file to reference a TDB triple store by default (instead of SDB).
Note: Support for SDB still exists.

How should this be tested?

Use the example.applicationSetup.n3 configuration in a new VIVO installation.
Verify that VIVO works as expected.
Verify that content is created in the TDB "hasTdbDirectory" location.

Interested parties

@VIVO-project/vivo-committers

@gneissone gneissone self-requested a review February 24, 2020 22:28
gneissone
gneissone previously approved these changes Feb 24, 2020
Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per discussion among committers and community response to the VIVO Triple Store Roadmap Proposal.

Only comment is I would suggest commenting out the SQL database connection settings in example.runtime.properties to avoid confusion.

@awoods
Copy link
Member Author

awoods commented Feb 24, 2020

@gneissone : updated per comment.

@gneissone
Copy link
Member

@gneissone : updated per comment.

I don't think the commit was pushed, I don't see any difference.

Copy link
Contributor

@EDemerzel EDemerzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@roflinn roflinn merged commit 7fdcd6e into vivo-project:master Feb 25, 2020
@awoods awoods deleted the vivo-1741 branch February 25, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants