Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jquery selector for capability map tabs #3921

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

milospp
Copy link
Contributor

@milospp milospp commented Nov 29, 2023

What does this pull request do?

Fixes the unresponsive behavior of capability map nodes in the Nemo theme when clicked. The issue stemmed from an incorrect jQuery selector used in the theme's jQuery version.

What's new?

Resolved the jQuery selector issue by adding single quotes to the value of the href attribute:
$(".titles li a[href='#" + name + "']")...

How should this be tested?

  1. Open the Capability Map tab.
  2. Search for an item.
  3. Click on a node to verify if it opens the information tab on the right side.
  4. Test this across all themes for thorough validation.

image

@chenejac chenejac marked this pull request as ready for review November 29, 2023 08:27
@gneissone
Copy link
Member

I know it's not the point of this issue and PR and it's a non-trivial task, but would be great if we could upgrade the jQuery version. The version VIVO uses is from 2016 and is flagged as a security risk. #3528

@chenejac chenejac linked an issue Dec 1, 2023 that may be closed by this pull request
@chenejac
Copy link
Contributor

chenejac commented Dec 1, 2023

I know it's not the point of this issue and PR and it's a non-trivial task, but would be great if we could upgrade the jQuery version. The version VIVO uses is from 2016 and is flagged as a security risk. #3528

Let's resolve this in the separate PR.

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milospp well done. Thanks

@chenejac chenejac merged commit 3fb8b6d into vivo-project:main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capability map in the nemo theme
3 participants